Skip to content

[Rector] add PHPUnitSetList::PHPUNIT_80#5328

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:update-rector-phpunit-rule
Nov 25, 2021
Merged

[Rector] add PHPUnitSetList::PHPUNIT_80#5328
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:update-rector-phpunit-rule

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Nov 15, 2021

Description
Follow-up: #5320

  • use assertStringContainsString instead of strpos()

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Copy Markdown
Member

@kenjis the AddParamTypeDeclarationRector should already fixed at rectorphp/rector-src#1239

I will try looking at why there is another error Rector\StaticTypeMapper\PhpDocParser\IdentifierTypeMapper::mapStatic() must implement interface PHPStan\Analyser\Scope, null given

@samsonasik
Copy link
Copy Markdown
Member

Fixing for error is "Rector\StaticTypeMapper\PhpDocParser\IdentifierTypeMapper::mapStatic() must implement interface PHPStan\Analyser\Scope, null given" coming at rectorphp/rector-src#1243

@samsonasik
Copy link
Copy Markdown
Member

@kenjis could you rebase latest develop, run composer update, and re-run rector to verify if the error is solved?

@kenjis kenjis force-pushed the update-rector-phpunit-rule branch from dd7092c to 7a37d77 Compare November 16, 2021 00:07
@samsonasik
Copy link
Copy Markdown
Member

Oh, it still error in other place:

vendor/bin/rector process --dry-run --no-progress-bar

Error: ] Could not process "system/I18n/Time.php" file, due to:                 
         "Argument 1 passed to                                                  
         Rector\StaticTypeMapper\PhpDocParser\IdentifierTypeMapper::mapStatic() 
         must implement interface PHPStan\Analyser\Scope, null given, called in 
         vendor/rector/rector/packages/StaticTypeMapper/PhpDocParser/IdentifierT
         ypeMapper.php:92". On line: 132  

I will check on rector side.

@samsonasik
Copy link
Copy Markdown
Member

fix on error above is coming to rector rectorphp/rector-src#1248

@samsonasik
Copy link
Copy Markdown
Member

@kenjis please rebase again as rector updated to 0.12.5, it should be working ok now ;)

@kenjis kenjis force-pushed the update-rector-phpunit-rule branch from 7a37d77 to 3cf95b5 Compare November 25, 2021 00:07
@kenjis kenjis merged commit 7c08819 into codeigniter4:develop Nov 25, 2021
@kenjis kenjis deleted the update-rector-phpunit-rule branch November 25, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants